Fix the regular expression escapes for more recent python versions. #343

tmolteno · 2024-11-07T05:26:25Z

The following syntaxWarnings appear in python 3.12.

scabha/basetypes.py:73: SyntaxWarning: invalid escape sequence '\w'
  match = re.fullmatch("((\w+)://)(.*)", value)

stimela/config.py:275: SyntaxWarning: invalid escape sequence '\$'
  env={key: value.replace('${', '\${') for key, value in os.environ.items()})

scabha/configuratt/resolvers.py:221: SyntaxWarning: invalid escape sequence '\['
  match = re.match("^(.*)\[(.*)\]$", incl)

stimela/backends/kube/__init__.py:198: SyntaxWarning: invalid escape sequence '\['
  event_format:  str = "=NOSUBST('\[k8s event type: {event.type}, reason: {event.reason}] {event.message}')"

scabha/cargo.py:527: SyntaxWarning: invalid escape sequence '\['
  attrs and info.append(f"[dim]\[{rich.markup.escape(', '.join(attrs))}][/dim]")

stimela/kitchen/recipe.py:509: SyntaxWarning: invalid escape sequence '\('
  if re.match('^\(.+\)$', step_spec):

stimela/kitchen/wranglers.py:207: SyntaxWarning: invalid escape sequence '\d'
  elif re.fullmatch('\d+', group):

stimela/commands/run.py:49: SyntaxWarning: invalid escape sequence '\w'
  match2 = re.fullmatch("^([\w.]+)::(.+)$", filename)

stimela/commands/run.py:87: SyntaxWarning: invalid escape sequence '\w'
  match2 = re.fullmatch("^([\w.]+)::(.+)$", filename)

The strings should be raw strings eg, "((\w+)://)(.*)" should become r'((\w+)://)(.*)', otherwise the \w will be treated as an escaped unicode character. Alternatively replace \w with \w.

See here for details.

…he strings should be raw strings eg, "((\w+)://)(.*)" -> r'((\w+)://)(.*)', otherwise the \w will be treated as an excaped unicode character.

o-smirnov

LGTM, thanks for the fixes!

Fix the regular expression escapes for more recent python versions. T…

cfb1e7e

…he strings should be raw strings eg, "((\w+)://)(.*)" -> r'((\w+)://)(.*)', otherwise the \w will be treated as an excaped unicode character.

o-smirnov approved these changes Nov 7, 2024

View reviewed changes

o-smirnov merged commit ace73a7 into caracal-pipeline:master Nov 7, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the regular expression escapes for more recent python versions. #343

Fix the regular expression escapes for more recent python versions. #343

tmolteno commented Nov 7, 2024

o-smirnov left a comment

Fix the regular expression escapes for more recent python versions. #343

Fix the regular expression escapes for more recent python versions. #343

Conversation

tmolteno commented Nov 7, 2024

o-smirnov left a comment

Choose a reason for hiding this comment